Remove SOURCE_DATE_EPOCH from all our builds#135
Merged
Conversation
This was a misguided attempt at some initial aspects of reproducibility. The actual goal is of dubious value compared to the amount of effort required, but the half-measure is outright incorrect/useless, and a consistent and repeated source of user confusion. This dramatically simplifies our build commands because all the annotations get set to the same value, so we can drop half the `docker buildx build` arguments.
yosifkit
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a misguided attempt at some initial aspects of reproducibility.
The actual goal is of dubious value compared to the amount of effort required, but the half-measure is outright incorrect/useless, and a consistent and repeated source of user confusion.
This dramatically simplifies our build commands because all the annotations get set to the same value, so we can drop half the
docker buildx buildarguments.See:
docker pull buildpack-deps:curldownloads ancient version buildpack-deps#166 (comment)Closes docker-library/buildpack-deps#166
(technically Closes docker/hub-feedback#2498 too, but I have no privileges there)
Also related in various ways:
SOURCE_DATE_EPOCHchanges thecreatedmetadata for base image layers (which are otherwise immutable 😅) moby/buildkit#4614meta.jqto prepare for signing andoci-importimplementation #17